From 91d35ad94050f5ec353e59f44c34648fc53a1196 Mon Sep 17 00:00:00 2001 From: David Malcolm Date: Wed, 21 Oct 2015 15:09:22 -0400 Subject: [PATCH 26/26] FIXME: fix libstdc++v3 testsuite With token range underlining, the libstdc++v3 testsuite starts showing numerous failures of the form: FAIL: 17_intro/using_namespace_std_tr1_neg.cc (test for excess errors) The excess errors turn out to be the source code and caret/underlines: using namespace std::tr1; // { dg-error "is not a namespace-name" } ^~~ However, looking at the results of a control build of r228618, I see the testsuite emit code and carets (albeit without underlines): using namespace std::tr1; // { dg-error "is not a namespace-name" } ^ but for some reason this is treated by dg.exp as: PASS: 17_intro/using_namespace_std_tr1_neg.cc (test for excess errors) It's not clear to me why the status quo isn't treated as generating "excess errors", but the attached patch explicitly disables carets and colorization, fixing this. --- libstdc++-v3/testsuite/lib/libstdc++.exp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libstdc++-v3/testsuite/lib/libstdc++.exp b/libstdc++-v3/testsuite/lib/libstdc++.exp index 88738b7..ac3654b 100644 --- a/libstdc++-v3/testsuite/lib/libstdc++.exp +++ b/libstdc++-v3/testsuite/lib/libstdc++.exp @@ -462,6 +462,8 @@ proc v3_target_compile { source dest type options } { global STATIC_LIBCXXFLAGS global tool + lappend options "additional_flags=-fno-diagnostics-show-caret -fdiagnostics-color=never" + if { [target_info needs_status_wrapper] != "" && [info exists gluefile] } { lappend options "libs=${gluefile}" lappend options "ldflags=${wrap_flags}" -- 1.8.5.3