From b61251456006fbbb13ccf4a0127307620787d28a Mon Sep 17 00:00:00 2001 From: David Malcolm Date: Fri, 4 Mar 2016 09:58:09 -0500 Subject: [PATCH 01/14] FIXME: non-working testcases for fixits for -Wsuggest-* --- gcc/testsuite/g++.dg/warn/Wsuggest-final.C | 16 +++++++++++++++- gcc/testsuite/g++.dg/warn/Wsuggest-override.C | 10 +++++++++- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/g++.dg/warn/Wsuggest-final.C b/gcc/testsuite/g++.dg/warn/Wsuggest-final.C index f1d419e..b1480c5 100644 --- a/gcc/testsuite/g++.dg/warn/Wsuggest-final.C +++ b/gcc/testsuite/g++.dg/warn/Wsuggest-final.C @@ -1,9 +1,23 @@ // { dg-do compile } -// { dg-options "-O2 -Wsuggest-final-types -Wsuggest-final-methods" } +// { dg-options "-O2 -Wsuggest-final-types -Wsuggest-final-methods -fdiagnostics-show-caret" } int c; struct A { // { dg-warning "final would enable devirtualization of 4 calls" } +/* { dg-begin-multiline-output "" } + struct A { + ^ + { dg-end-multiline-output "" } */ + virtual void a() {} // { dg-warning "final would enable devirtualization of 2 calls" } +/* { dg-begin-multiline-output "" } + virtual void a() {} + ^ + { dg-end-multiline-output "" } */ + virtual void b() {c++;} // { dg-warning "final would enable devirtualization of 2 calls" } +/* { dg-begin-multiline-output "" } + virtual void b() {c++;} + ^ + { dg-end-multiline-output "" } */ }; void t(struct A *a) diff --git a/gcc/testsuite/g++.dg/warn/Wsuggest-override.C b/gcc/testsuite/g++.dg/warn/Wsuggest-override.C index f820f4b..8d567b2 100644 --- a/gcc/testsuite/g++.dg/warn/Wsuggest-override.C +++ b/gcc/testsuite/g++.dg/warn/Wsuggest-override.C @@ -1,5 +1,5 @@ // { dg-do compile } -// { dg-options "-std=c++11 -Wsuggest-override" } +// { dg-options "-std=c++11 -Wsuggest-override -fdiagnostics-show-caret" } struct A { A(); @@ -16,8 +16,16 @@ struct B : A B(); virtual ~B(); virtual void f(); // { dg-warning "can be marked override" } +/* { dg-begin-multiline-output "" } + virtual void f(); + ^ + { dg-end-multiline-output "" } */ virtual int bar() override; int c(); operator int(); virtual operator float(); // { dg-warning "can be marked override" } +/* { dg-begin-multiline-output "" } + virtual operator float(); + ^~~~~~~~ + { dg-end-multiline-output "" } */ }; -- 1.8.5.3