From 4c052e1528370a5f3f7c023ea9dd8eede16e4841 Mon Sep 17 00:00:00 2001 From: David Malcolm Date: Mon, 9 Jul 2018 17:40:23 -0400 Subject: [PATCH 43/46] Add some test coverage In particular, note how this allows us to highlight specific loops in testcases (via dg-remark), and to highlight the specific lines that cause problems to the vectorizer (via dg-message). gcc/testsuite/ChangeLog: * gcc.dg/vect/vect-alias-check-4.c: Add -fremarks to options. Add dg-remark and dg-message directives to the cover the expected vectorization failure reports. * gcc.dg/vect/vect-remarks-1.c: New test. --- gcc/testsuite/gcc.dg/vect/vect-alias-check-4.c | 11 +++++++---- gcc/testsuite/gcc.dg/vect/vect-remarks-1.c | 18 ++++++++++++++++++ 2 files changed, 25 insertions(+), 4 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/vect/vect-remarks-1.c diff --git a/gcc/testsuite/gcc.dg/vect/vect-alias-check-4.c b/gcc/testsuite/gcc.dg/vect/vect-alias-check-4.c index 1e5fc27..b08b4b4 100644 --- a/gcc/testsuite/gcc.dg/vect/vect-alias-check-4.c +++ b/gcc/testsuite/gcc.dg/vect/vect-alias-check-4.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-require-effective-target vect_int } */ -/* { dg-additional-options "--param vect-max-version-for-alias-checks=0" } */ +/* { dg-additional-options "--param vect-max-version-for-alias-checks=0 -fremarks" } */ #define N 16 @@ -14,22 +14,25 @@ union u { struct s2 f; struct s3 g; }; void f1 (int a[][N], int b[][N]) { - for (int i = 0; i < N; ++i) + for (int i = 0; i < N; ++i) /* { dg-remark "couldn't vectorize loop" } */ a[0][i] += b[0][i]; + /* { dg-message "will not create alias checks, as --param vect-max-version-for-alias-checks == 0" "" { target *-*-* } .-2 } */ } void f2 (union u *a, union u *b) { - for (int i = 0; i < N; ++i) + for (int i = 0; i < N; ++i) /* { dg-remark "couldn't vectorize loop" } */ a->f.b.a[i] += b->g.e.a[i]; + /* { dg-message "will not create alias checks, as --param vect-max-version-for-alias-checks == 0" "" { target *-*-* } .-2 } */ } void f3 (struct s1 *a, struct s1 *b) { - for (int i = 0; i < N - 1; ++i) + for (int i = 0; i < N - 1; ++i) /* { dg-remark "couldn't vectorize loop" } */ a->a[i + 1] += b->a[i]; + /* { dg-message "possible dependence between data-refs" "" { target *-*-* } .-2 } */ } /* { dg-final { scan-tree-dump-not "LOOP VECTORIZED" "vect" } } */ diff --git a/gcc/testsuite/gcc.dg/vect/vect-remarks-1.c b/gcc/testsuite/gcc.dg/vect/vect-remarks-1.c new file mode 100644 index 0000000..5006742 --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/vect-remarks-1.c @@ -0,0 +1,18 @@ +/* { dg-do compile } */ +/* { dg-options "-fremarks -O3" } */ + +extern void accumulate (int x, int *a); + +int test_1 (int arr[], int n) +{ + int sum = 0; + for (int i = 0; i < n; ++i) /* { dg-remark "couldn't vectorize loop" } */ + accumulate (arr[i], &sum); /* { dg-message "statement clobbers memory: 'accumulate .*'" } */ + return sum; +} + +void test_2 (int *dst, int *src_a, int *src_b, int n) +{ + for (int i = 0; i < n; i++) /* { dg-remark "loop vectorized" } */ + dst[i] = src_a[i] + src_b[i]; +} -- 1.8.5.3