From 0c9a17edc5208cd9f5fc0d19b8cd4d57ded3e6d2 Mon Sep 17 00:00:00 2001
From: David Malcolm <dmalcolm@redhat.com>
Date: Fri, 10 Jul 2020 14:51:37 -0400
Subject: [PATCH 302/315] FIXME: tweaks to store2.cc

---
 gcc/analyzer/store2.cc | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/gcc/analyzer/store2.cc b/gcc/analyzer/store2.cc
index 14d50cdbf56..7772b477d0c 100644
--- a/gcc/analyzer/store2.cc
+++ b/gcc/analyzer/store2.cc
@@ -508,7 +508,7 @@ binding_cluster2::bind_compound_sval (store2_manager *mgr,
     }
 }
 
-/* FIXME.  */
+/* Remove all bindings affecting REG within this cluster.  */
 
 void
 binding_cluster2::clobber_region (store2_manager *mgr, const region2 *reg)
@@ -528,7 +528,9 @@ binding_cluster2::purge_region (store2_manager *mgr, const region2 *reg)
   m_map.remove (binding);
 }
 
-/* FIXME.  */
+/* Mark REG within this cluster as being filled with zeroes.
+   Remove all bindings, add a default binding to zero, and clear the
+   TOUCHED flag.  */
 
 void
 binding_cluster2::zero_fill_region (store2_manager *mgr, const region2 *reg)
@@ -545,6 +547,7 @@ binding_cluster2::zero_fill_region (store2_manager *mgr, const region2 *reg)
 						  cst_sval);
   bind (mgr, reg, bound_sval, BK_default);
 
+  // FIXME: is the granularity of this flag wrong?
   m_touched = false;
 }
 
@@ -1331,6 +1334,8 @@ store2::summarize_to_pp (pretty_printer *pp, bool simple) const
 #endif
 }
 
+/* FIXME.  */
+
 const svalue2 *
 store2::get_any_binding (store2_manager *mgr, const region2 *reg)
 {
@@ -1341,6 +1346,8 @@ store2::get_any_binding (store2_manager *mgr, const region2 *reg)
   return (*cluster_slot)->get_any_binding (mgr, reg);
 }
 
+/* FIXME.  */
+
 void
 store2::set_value (store2_manager *mgr, const region2 *lhs_reg,
 		   const svalue2 *rhs_sval, enum binding_kind kind)
-- 
2.26.2